Topic: Sidenav skin variable is confusing
gordysc pro asked 5 years ago
Expected behavior
Specifying "skin-sidenav" should allow be to overwrite the skin color for the sidenav
Actual behavior
I had to look through the source code to find the sidenav color is being dictated by the "skin-flat" variable. That is not straightforward at all. Why is flat = sidenav background color? Wouldn't using a variable like "skin-sidenav" make more sense?
This kind of really brings me to the following feedback as I've really enjoyed this product the past few years.. I'd really like to see this system removed and the _custom.scss
files reintroduced. The newly introduced "skin" architecture:
- Is a more restrictive version of a system people already know (scss/css)
- Is a huge pain point for people to upgrade
- Makes it harder for people to adopt your product as they now have to relearn what/where/which "skin" variables impact the styling
- Is harder to identify what variables impacts what styling, rather than a well known established existing system (scss/css).
- Makes future releases more risky as you may change which variables impact which styling.
- Doesn't introduce any significant advantages over scss/css
- Will cost you more in support/answering questions/documentation
- Decreases the overall developer experience using your product
I can't honestly think of a solid pro here for this "skin" architecture that isn't already addressed in a better, more flexible, and existing system (scss/css). What was the thought process behind this that we don't already solve with scss/css in a less clunky manner?
Resources (screenshots, code snippets etc.)
Arkadiusz Idzikowski staff answered 5 years ago
We will discuss the problem with variable names with our design team and consider updating them. However, that would be breaking change and we cannot introduce it in the near future.
The change we introduced recently were related to the modularity of the styles and make the bundle size much smaller. We no longer recommend using _custom.scss
because you need to add this file to your node_modules and it's hard to maintain.
Could you provide more details about current problems with skins? We would be happy to hear how we can upgrade our product.
FREE CONSULTATION
Hire our experts to build a dedicated project. We'll analyze your business requirements, for free.
Answered
- ForumUser: Pro
- Premium support: No
- Technology: MDB Angular
- MDB Version: 8.0.0
- Device: Any
- Browser: Any
- OS: Any
- Provided sample code: Yes
- Provided link: No