Topic: Criticism: Please don't abuse the CSS Rule "Important" and don't create dependencies to projects that you're not actively developing.
Basically as the title says.
I was left absolutely confused, why so many of my CSS rules were suddenly not working anymore after the newest update, only to find out you have been using the !important rule in a rather abusive manner. It invalidated almost 20% of my existing CSS rules for my project.
Also, please don't use libraries like Chart.js as a dependency in your project anymore. With each update of the MDB I'm dreading to actually follow through, because I can be almost certain that something won't be working as it should. Less dependencies would make your project easier to maintain as well as easier to test for errors.
Dear @ak.leimrey
Actually, we're working on scss refactor, so we can drop the !important rules. We know, that this is bad practice to use it, but sometimes it was necessary due to the encapsulation of the styles.
About Charts - we're not including this library in your project. User has to install it (or not, if ChartsModule isn't used in the application). Why you think, that we're including it in our code?
Best Regards,
Damian
ak.leimrey pro commented 5 years ago
I apologize. The latter part was somewhat of an assumption. While not a hard-dependency, the chart module should potentially still not be really part of the overall project. As we could see, some versions of the chart.js are strictly incompatible that leaves you with the dirty work to find out why it doesn't work.
However, overall the issue is fully explained from your end, so I consider this ticket done with.
FREE CONSULTATION
Hire our experts to build a dedicated project. We'll analyze your business requirements, for free.
Resolved
- ForumUser: Pro
- Premium support: No
- Technology: MDB Angular
- MDB Version: 7.5.4
- Device: PC
- Browser: Chrome
- OS: Windows
- Provided sample code: Yes
- Provided link: No